Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-16853 remove raw URLs from checks, handle via subtype map #3663

Merged
merged 2 commits into from
May 2, 2024
Merged

CLDR-16853 remove raw URLs from checks, handle via subtype map #3663

merged 2 commits into from
May 2, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 30, 2024

CLDR-16853

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Apr 30, 2024
@srl295
Copy link
Member Author

srl295 commented Apr 30, 2024

I think I rooted out all of the "For what to do" and "See" type messages. They need to be handled via subtype map. Plus, it should be noted that

oops, i found a couple of others.. Plus they look really bad in the dashboard, waste of space saying the same thing 3x per row

image

@srl295 srl295 marked this pull request as draft April 30, 2024 17:39
@srl295 srl295 marked this pull request as ready for review May 2, 2024 22:18
@srl295 srl295 merged commit f1242b4 into unicode-org:main May 2, 2024
10 checks passed
@srl295 srl295 deleted the cldr-16853/fixlinks branch May 2, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati approved these changes

@AEApple AEApple Awaiting requested review from AEApple

@btangmu btangmu Awaiting requested review from btangmu

@pedberg-icu pedberg-icu Awaiting requested review from pedberg-icu

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @macchiati