fix: not working long page screenshot #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2025
|
Thanks for this great improvement to the screenshot logic! The refactoring makes the code more efficient by avoiding unnecessary scrolling operations. I've approved the PR and will merge it. As a small enhancement, we could add error handling to page_need_scroll, but I can follow up with that change. By the way, I really appreciate your contribution. If you're interested in becoming a regular collaborator, we have a Discord community where we discuss features and improvements. Let me know if you'd like to join, if you are please share your email address I will share. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for long page screenshot.
Error:
The fixed
SCREENSHOT_HEIGHT_TRESHOLD(default 10000) was too large, preventing scrolling for most pages. This resulted in only single viewport screenshots instead of full-page captures.Fix:
Replaced the threshold check with a comparison of
scrollHeightandviewportHeight. Scrolling now occurs whenscrollHeightexceedsviewportHeight, ensuring full-page screenshots.