-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version 0.1.9 #125
Merged
Merged
Latest version 0.1.9 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omment out excess code
j-c-gibson
requested review from
hareball90 and
twomagpi
and removed request for
hareball90
November 21, 2024 14:42
twomagpi
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge request seems sensible summation of progress to 0.1.9 milestone,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
Version 0.1.9. The new features can be found in the release notes in the documentation.
Checks
This is an itemised checklist for the QA process within UKHSA and represents the bare minimum a QA should be.
To the reviewer: Check the boxes once you have completed the checks below.
This is a basic form of Smoke Testing
Data and security
Sensible
Documentation
How to QA this PR
Before accepting the PR and merging to
main
ormaster
, please follow these steps on a terminal in your development instance:git status
check what branch you are on and if you have any uncommitted changes.git commit
if you would like to keep the changes you have made on your current branch.git stash
if you do not want to keep these changes, although you can recover these later.git checkout main
orgit checkout master
to go to the branch that will be merged to.git pull origin main
orgit pull origin master
fetches the most up to date git info on this branch.git branch -a
lists all the available branches.git checkout BRANCHNAME-FOR-PR
moves you into the branch to QA.git pull origin BRANCHNAME-FOR-PR
ensures you have the most recent changes for the PR.pre-commit
. This runs some automated checks to check the code is well formatted and does not contain data.