Proper checking of vararg overrides with JSpecify annotations #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
=========================================
Coverage 88.13% 88.14%
- Complexity 2231 2234 +3
=========================================
Files 85 85
Lines 7232 7237 +5
Branches 1437 1439 +2
=========================================
+ Hits 6374 6379 +5
Misses 431 431
Partials 427 427 ☔ View full report in Codecov by Sentry. |
yuxincs
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1113
We weren't calling the right API to check the nullability of a varargs argument when checking valid overriding. Most of this PR is tests to check handling of most of the cases.