Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactoring] Wrap calls to Types.subst and Types.memberType #1115

Merged
merged 4 commits into from
Dec 26, 2024

Conversation

msridhar
Copy link
Collaborator

This is in preparation to attempt to fix #1091. Just a refactoring, no behavior changes.

@msridhar msridhar enabled auto-merge (squash) December 25, 2024 17:41
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.13%. Comparing base (17df87f) to head (7bde4cd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../uber/nullaway/generics/TypeSubstitutionUtils.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1115   +/-   ##
=========================================
  Coverage     88.13%   88.13%           
- Complexity     2229     2231    +2     
=========================================
  Files            84       85    +1     
  Lines          7223     7232    +9     
  Branches       1437     1437           
=========================================
+ Hits           6366     6374    +8     
- Misses          430      431    +1     
  Partials        427      427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit 7cb6b98 into master Dec 26, 2024
12 checks passed
@msridhar msridhar deleted the refactor-subst-and-member-type branch December 26, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatched type parameter nullability
2 participants