Fix issue with annotations in module-info.java files
#1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1109 +/- ##
=========================================
Coverage 88.10% 88.10%
- Complexity 2208 2209 +1
=========================================
Files 84 84
Lines 7177 7179 +2
Branches 1425 1426 +1
=========================================
+ Hits 6323 6325 +2
Misses 430 430
Partials 424 424 ☔ View full report in Codecov by Sentry. |
stefanheule
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
javacgeneratesAssignmentTrees for assigning annotation attributes that, in the context of amodule-info.javafile, was causing a crash. Just skip analysis of such assignments.