Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InferredJARModelsHandler #1079

Merged
merged 23 commits into from
Dec 16, 2024
Merged

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Nov 22, 2024

Now, all logic for parsing loading astubx files is consolidated into the LibraryModelsHandler.ExternalStubxLibraryModels class and is uniform for astubx files generated via JarInfer or from source code, which will ease future bug fixes and changes.

We copied over the logic from InferredJARModelsHandler for loading Android SDK models if present. We also update the logic for ExternalStubxLibraryModels.nonNullParameters() and ExternalStubxLibraryModels.nullableReturns() to pull in all the relevant info from the parsed astubx file.

Fixes #1072

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 88.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.09%. Comparing base (9ff664a) to head (9109f86).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...m/uber/nullaway/handlers/LibraryModelsHandler.java 87.93% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1079      +/-   ##
============================================
+ Coverage     88.01%   88.09%   +0.07%     
+ Complexity     2228     2204      -24     
============================================
  Files            85       84       -1     
  Lines          7212     7175      -37     
  Branches       1428     1423       -5     
============================================
- Hits           6348     6321      -27     
+ Misses          436      431       -5     
+ Partials        428      423       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar changed the title [WIP] Remove inferred jar models handler Remove InferredJARModelsHandler Dec 15, 2024
@msridhar msridhar marked this pull request as ready for review December 15, 2024 20:33
@msridhar msridhar merged commit cb3ff51 into master Dec 16, 2024
11 checks passed
@msridhar msridhar deleted the remove-inferred-jar-models-handler branch December 16, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify InferredJARModelsHandler and LibraryModelsHandler
2 participants