Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github Action to Compile Examples on ESP8266 #1258

Merged
merged 7 commits into from
Jun 21, 2021
Merged

Added Github Action to Compile Examples on ESP8266 #1258

merged 7 commits into from
Jun 21, 2021

Conversation

shafr
Copy link
Contributor

@shafr shafr commented Jun 9, 2021

Hi, I've added compilation of all examples, so you would see if something would fail here in Github.
There are few tests failing - not sure what version of ArduinoJson it should be using - latest 6 fails with missing methods.

Please squash while merging.

@tablatronix
Copy link
Collaborator

Yeah there is an example that needs to be updated I think I just need to copy it over from hotfixes or a pr

@tablatronix tablatronix merged commit cdd8a40 into tzapu:master Jun 21, 2021
@tablatronix
Copy link
Collaborator

Thanks , I will try to clean up examples, need to add esp32

@tablatronix tablatronix added Documentation Flagged for docs ESP32 Esp 32 related issue In Progress Task Non Code Related Task labels Jun 21, 2021
@tablatronix
Copy link
Collaborator

Thanks all , travis is down (migrate to .com required) I do not have repo access to migrate it, so this will be useful. I will fix the arduinojson example and just remove 5.x entirelty.

@tablatronix tablatronix added this to the dev milestone Jun 21, 2021
@tablatronix
Copy link
Collaborator

tablatronix commented Jun 21, 2021

-[ ] add pull_request ?
-[ ] add branches filter (master)

to trigger

@shafr
Copy link
Contributor Author

shafr commented Jun 22, 2021

done in #1264

Later probably also path filtering can be done - to ignore readme.md or some other non-essential paths.

Also not sure how true checks are with a library that is referenced from git, especially if it is developed in custom branch.

@tablatronix
Copy link
Collaborator

Thanks I will look it over and rework as needed, I will be cleaning up examples anyway for a beta release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flagged for docs ESP32 Esp 32 related issue In Progress Task Non Code Related Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants