-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Github Action to Compile Examples on ESP8266 #1258
Conversation
Yeah there is an example that needs to be updated I think I just need to copy it over from hotfixes or a pr |
Thanks , I will try to clean up examples, need to add esp32 |
Thanks all , travis is down (migrate to .com required) I do not have repo access to migrate it, so this will be useful. I will fix the arduinojson example and just remove 5.x entirelty. |
-[ ] add pull_request ? to trigger |
done in #1264 Later probably also path filtering can be done - to ignore readme.md or some other non-essential paths. Also not sure how true checks are with a library that is referenced from git, especially if it is developed in custom branch. |
Thanks I will look it over and rework as needed, I will be cleaning up examples anyway for a beta release soon |
Hi, I've added compilation of all examples, so you would see if something would fail here in Github.
There are few tests failing - not sure what version of ArduinoJson it should be using - latest 6 fails with missing methods.
Please squash while merging.