-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add tracer session management endpoints to LangSmith API spec #169
Conversation
WalkthroughThe pull request introduces enhancements to the LangSmith API specification, focusing on tracer sessions management. The changes expand the existing API capabilities by adding new endpoints for updating, deleting, and managing tracer sessions and their associated filter views. These modifications provide more comprehensive control over tracer session lifecycle and filtering mechanisms within the OpenAPI specification. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/libs/LangSmith/openapi.yaml (3)
16901-16904
: New prompt optimization feature configuration addedThe new configuration flags for prompt optimization have been added:
prompt_optimization: title: Prompt Optimization type: boolean default: false prompt_optimization_jobs_enabled: title: Prompt Optimization Jobs Enabled type: boolean default: false
Consider adding documentation about the relationship between these two flags and when each should be enabled. The distinction between
prompt_optimization
andprompt_optimization_jobs_enabled
may not be immediately clear to API consumers.
Line range hint
1-7
: Security scheme configuration looks good but could be enhancedThe API uses a comprehensive security scheme including API keys, tenant IDs, and bearer tokens. However, consider adding rate limiting information to the OpenAPI spec.
Consider adding rate limiting headers and response codes (429 Too Many Requests) to the specification to better document API limits.
Line range hint
422-424
: Validation error schema is well definedThe HTTPValidationError schema provides good structure for error responses.
Consider adding examples of error responses to help API consumers better understand the error format.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/libs/LangSmith/Generated/LangSmith.Models.OrganizationConfig.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/LangSmith/openapi.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test / Build, test and publish
Summary by CodeRabbit