Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Add tracer session management endpoints to LangSmith API spec #169

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Jan 10, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced tracer session management with new capabilities:
      • Update existing tracer sessions
      • Delete specific tracer sessions
      • Create and manage filter views for tracer sessions
    • Added more flexible API endpoints for session and view interactions

Copy link

coderabbitai bot commented Jan 10, 2025

Walkthrough

The pull request introduces enhancements to the LangSmith API specification, focusing on tracer sessions management. The changes expand the existing API capabilities by adding new endpoints for updating, deleting, and managing tracer sessions and their associated filter views. These modifications provide more comprehensive control over tracer session lifecycle and filtering mechanisms within the OpenAPI specification.

Changes

File Change Summary
src/libs/LangSmith/openapi.yaml - Added patch endpoint for updating tracer sessions
- Added delete endpoint for removing tracer sessions
- Introduced get and post endpoints for filter views
- Updated request/response schemas for tracer sessions

Poem

🐰 In the realm of LangSmith's trace,
New endpoints dance with coding grace
Patch, delete, and view with might
Sessions now shine ever so bright!
A rabbit's API ballet, so neat 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot merged commit 29990e0 into main Jan 10, 2025
2 of 4 checks passed
@coderabbitai coderabbitai bot changed the title feat:@coderabbitai feat:Add tracer session management endpoints to LangSmith API spec Jan 10, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
src/libs/LangSmith/openapi.yaml (3)

16901-16904: New prompt optimization feature configuration added

The new configuration flags for prompt optimization have been added:

        prompt_optimization:
          title: Prompt Optimization
          type: boolean
          default: false
        prompt_optimization_jobs_enabled:
          title: Prompt Optimization Jobs Enabled
          type: boolean
          default: false

Consider adding documentation about the relationship between these two flags and when each should be enabled. The distinction between prompt_optimization and prompt_optimization_jobs_enabled may not be immediately clear to API consumers.


Line range hint 1-7: Security scheme configuration looks good but could be enhanced

The API uses a comprehensive security scheme including API keys, tenant IDs, and bearer tokens. However, consider adding rate limiting information to the OpenAPI spec.

Consider adding rate limiting headers and response codes (429 Too Many Requests) to the specification to better document API limits.


Line range hint 422-424: Validation error schema is well defined

The HTTPValidationError schema provides good structure for error responses.

Consider adding examples of error responses to help API consumers better understand the error format.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9db5e5d and cefa29e.

⛔ Files ignored due to path filters (1)
  • src/libs/LangSmith/Generated/LangSmith.Models.OrganizationConfig.g.cs is excluded by !**/generated/**
📒 Files selected for processing (1)
  • src/libs/LangSmith/openapi.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Test / Build, test and publish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant