Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Update OpenAPI specification with new endpoints for LangSmith API #165

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Jan 3, 2025

Summary by CodeRabbit

  • New Features
    • Added comprehensive API endpoints for:
      • Annotation queue management
      • Service account administration
      • Custom chart creation and management
      • Playground settings configuration
      • Model price map handling
      • Usage limit controls
      • Prompt and repo management
      • Comment and event tracking systems

Copy link

coderabbitai bot commented Jan 3, 2025

Walkthrough

The pull request introduces comprehensive updates to the LangSmith API's OpenAPI specification, significantly expanding the API's capabilities. The changes include new endpoints across multiple domains such as annotation queues, service accounts, custom charts, playground settings, model price maps, usage limits, TTL settings, prompts, feedback configurations, repositories, comments, and events. These additions provide more granular control and management functionalities within the LangSmith platform.

Changes

File Change Summary
src/libs/LangSmith/openapi.yaml - Added endpoints for annotation queues management
- Added service accounts management endpoints
- Added custom charts management endpoints
- Added playground settings management endpoints
- Added model price maps management endpoints
- Added usage limits and TTL settings endpoints
- Added prompt and prompt canvas invocation endpoints
- Added feedback configurations management endpoints
- Added repositories management endpoints
- Added comments management endpoints
- Added events creation endpoints

Poem

🐰 In the realm of LangSmith's API delight,
New endpoints bloom with technical might
Queues and charts, accounts galore
Playgrounds dancing from shore to shore
A rabbit's code, expanding with glee! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot merged commit 9eb67f0 into main Jan 3, 2025
2 of 4 checks passed
@coderabbitai coderabbitai bot changed the title feat:@coderabbitai feat:Update OpenAPI specification with new endpoints for LangSmith API Jan 3, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
src/libs/LangSmith/openapi.yaml (3)

Line range hint 1-7: Consider improving API versioning and server configuration

A few suggestions to enhance the API configuration:

  1. Consider aligning the info version (0.1.0) with the API path version (/v1)
  2. Consider using server variables to support different environments (e.g., development, staging, production)
servers:
  - url: https://{environment}.smith.langchain.com
    variables:
      environment:
        default: api
        enum:
          - api          # Production
          - api-staging  # Staging
          - api-dev     # Development

Line range hint 16000-16100: Consider enhancing batch operations error handling

For batch operations like /api/v1/runs/batch, consider adding:

  1. Structured error responses that indicate which items failed in the batch
  2. Support for partial success/failure scenarios
  3. Clear documentation of batch size limits and timeout behavior

Example enhancement:

responses:
  '200':
    description: Successful Response
    content:
      application/json:
        schema:
          type: object
          properties:
            succeeded:
              type: array
              items:
                type: string
                format: uuid
            failed:
              type: array
              items:
                type: object
                properties:
                  id:
                    type: string
                    format: uuid
                  error:
                    type: string

Line range hint 1-16860: Consider enhancing schema documentation

The OpenAPI specification would benefit from:

  1. Adding more descriptive field descriptions using the description property
  2. Documenting the implications of nullable fields
  3. Including examples for complex schema objects

Example enhancement:

TracerSession:
  description: |
    Represents a tracing session that groups related runs together.
    Sessions can be used for monitoring, debugging and analyzing runs.
  properties:
    trace_tier:
      description: |
        Determines how long the trace data is retained:
        - longlived: Retained for extended periods
        - shortlived: Retained for a shorter duration
    tenant_id:
      description: Unique identifier of the tenant owning this session
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a25045 and 85424e8.

⛔ Files ignored due to path filters (1)
  • src/libs/LangSmith/Generated/LangSmith.Models.OrganizationConfig.g.cs is excluded by !**/generated/**
📒 Files selected for processing (1)
  • src/libs/LangSmith/openapi.yaml (1 hunks)
🔇 Additional comments (1)
src/libs/LangSmith/openapi.yaml (1)

16857-16860: New feature: Experiment Page v2 configuration added

The configuration includes a new feature flag enable_experiment_page_v2 for controlling access to a new version of the experiment page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant