Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the optional version variable to the managed rules type #114

Merged
merged 2 commits into from
May 8, 2023

Conversation

sheenamt
Copy link
Contributor

@sheenamt sheenamt commented May 8, 2023

Changes proposed in this pull request:

This update allows the option to specify which version of the Managed Rules to use in the Web ACL. If nothing is specified, the default rule set will be used.

Example usage:

module "wafv2" {
source  = "trussworks/wafv2/aws"

managed_rules = [
    { "name" : "AWSManagedRulesCommonRuleSet",
      "override_action" : "count",
      "priority" : 10,
      "rule_action_override" : [],
      "vendor_name" : "AWS",
      "version" : "Version_2.0"
    }
  ]

@sheenamt sheenamt requested a review from rpdelaney May 8, 2023 19:48
@rpdelaney
Copy link
Contributor

optional is magic

@rpdelaney rpdelaney merged commit 679061b into main May 8, 2023
@rpdelaney rpdelaney deleted the add-optional-rules-versioning branch May 8, 2023 20:16
@rpdelaney
Copy link
Contributor

Shipped in 2.9.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants