Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to SimpleUnPack #89

Merged
merged 3 commits into from
Apr 6, 2023
Merged

switch to SimpleUnPack #89

merged 3 commits into from
Apr 6, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Mar 18, 2023

See trixi-framework/Trixi.jl#1376 and trixi-framework/Trixi.jl#1367. This reduces package cache sizes quite a bit on Julia v1.9 without performance penalty.

jlchan
jlchan previously approved these changes Apr 6, 2023
@jlchan
Copy link

jlchan commented Apr 6, 2023

Not sure if I should review PRs on TrixiParticles.jl, but this seems pretty straightforward.

Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@efaulhaber efaulhaber merged commit 109cd4a into main Apr 6, 2023
@ranocha ranocha deleted the hr/SimpleUnPack branch April 6, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants