Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SolutionSavingCallback #3

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

efaulhaber
Copy link
Member

No description provided.

@efaulhaber efaulhaber requested a review from LasNikas September 7, 2022 15:42
@sloede
Copy link
Member

sloede commented Sep 7, 2022

I really don't want to interfere, but if there is a chance that you could name that callback such that it is not close-but-not-exactly-the-same as in Trixi, I would really appreciate it 😬

@efaulhaber
Copy link
Member Author

I tried to be consistent with the ...ingCallback naming convention of DiffEqCallbacks, which is not used in Trixi for some reason.

@sloede
Copy link
Member

sloede commented Sep 7, 2022

Alas... It's up to you

@efaulhaber efaulhaber merged commit aebfeac into trixi-framework:main Sep 8, 2022
@efaulhaber efaulhaber deleted the saving-callback branch September 8, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants