Add fluid-structure interaction #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efaulhaber
commented
Nov 29, 2022
BenSimpson-365
previously approved these changes
Nov 29, 2022
LasNikas
previously approved these changes
Nov 30, 2022
efaulhaber
dismissed stale reviews from LasNikas and BenSimpson-365
via
2761806
LasNikas
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LasNikas @BenSimpson-365 Please put some extra focus on 0420b5c, since that's the only commit here that we haven't done in pair programming. But, of course, also check the rest of the PR.
I added TODOs to everything that's hardcoded or commented out. We can ignore this for now and fix it in separate PRs into dev.