Big refactoring: extract schemes and get rid of container types #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change directory structure Co-authored-by: Erik Faulhaber <[email protected]> * adapt tests * change include order --------- Co-authored-by: Erik Faulhaber <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 50.29% 49.77% -0.53%
==========================================
Files 38 38
Lines 2201 2224 +23
==========================================
Hits 1107 1107
- Misses 1094 1117 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…` stuff from the boundary container (#148) * Make dispatching more readable * Implement suggestions * Make things consistent
* Fix includes and unit tests * Update src/schemes/solid/total_lagrangian_sph/penalty_force.jl Co-authored-by: LasNikas <[email protected]> --------- Co-authored-by: LasNikas <[email protected]>
* Merge test files to get coverage back up again * Reformat code
* `FluidParticleContainer` to `WeaklyCompressibleSPHSystem` * `SolidParticleContainer` to `TotalLagrangianSPHSystem` * `BoundaryParticleContainer` to `BpundarySPHSystem` * `ParticleContainer` to `SPHSystem` * make examples consistent * formatting * rename variables * undo file rename * rename again * apply formatter * fix tests * fix merge conflicts * fix again * apply formatter * fix tests * remove infiltrator * implement suggestions
* Add `InitialCondition` * Use `InitialCondition` in `Semidiscretization` * Revert "Use `InitialCondition` in `Semidiscretization`" This reverts commit 479719b. * Store initial condition in systems * Adapt shapes * Remove `MergeShapes` * Start adapting example files * Fix undefined values * Only set current and not initial coordinates of solids in `restart_with` * Fix examples * Fix tests * Reformat code * Implement suggestions * Reformat code * Move smoothing kernel check before acceleration check The default acceleration depends on the smoothing kernel dimensionality, so passing a wrong smoothing kernel yielded "acceleration must be of length", which was confusing.
* formatting * adapt include order * extract boundary models * mv function into corresponding files * implement suggestions
efaulhaber
changed the title
LasNikas
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big refactoring according to #129.
Closes #129.