Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract function to fix NHS on macOS ARM #137

Merged
merged 4 commits into from
May 10, 2023

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber added the bug Something isn't working label May 9, 2023
@efaulhaber efaulhaber requested a review from LasNikas May 9, 2023 16:33
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #137 (89a873e) into main (2b39de9) will increase coverage by 0.22%.
The diff coverage is 93.57%.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   48.94%   49.17%   +0.22%     
==========================================
  Files          37       37              
  Lines        2229     2241      +12     
==========================================
+ Hits         1091     1102      +11     
- Misses       1138     1139       +1     
Flag Coverage Δ
unitandintegration 49.17% <93.57%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/fsi/bending_beam_2d.jl 0.00% <ø> (ø)
examples/fsi/dam_break_gate_2d.jl 0.00% <ø> (ø)
test/integration/containers/fluid_container.jl 50.00% <ø> (ø)
test/unit/setups/circular_shape.jl 100.00% <ø> (ø)
test/unit/setups/rectangular_shape.jl 87.50% <ø> (ø)
src/setups/circular_shape.jl 96.72% <71.42%> (-1.59%) ⬇️
src/setups/rectangular_shape.jl 91.93% <76.92%> (-0.80%) ⬇️
src/setups/rectangular_tank.jl 94.40% <97.50%> (ø)
src/sph/neighborhood_search.jl 79.00% <100.00%> (+1.68%) ⬆️

@efaulhaber efaulhaber enabled auto-merge (squash) May 10, 2023 13:23
@efaulhaber efaulhaber merged commit 81c2daa into trixi-framework:main May 10, 2023
@efaulhaber efaulhaber deleted the nhs-arm branch May 19, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants