Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NHS with coordinates array instead of coordinates function #127

Merged
merged 3 commits into from
May 3, 2023

Conversation

efaulhaber
Copy link
Member

This may seem like a step back from #121, but now the NHS can be updated both by passing an array or by passing a coordinate function (for maximum flexibility of the NHS).
When we update and initialize the NHS from the semidiscretization, however, we use the more high-level coordinate array, which allows us to use different NHS implementations that work with coordinate arrays and not coordinate functions (for maximum flexibility of the semidiscretization).

This PR specifically prepares the NHS update to work with CellListMap.jl.

Depends on #68.

@efaulhaber efaulhaber force-pushed the update-nhs-with-array branch from f0a271a to fd59712 Compare May 2, 2023 13:06
@efaulhaber efaulhaber marked this pull request as ready for review May 2, 2023 13:06
@efaulhaber efaulhaber requested a review from LasNikas May 2, 2023 13:07
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #127 (fdefc4b) into main (c5fc752) will decrease coverage by 0.02%.
The diff coverage is 22.58%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   49.10%   49.08%   -0.02%     
==========================================
  Files          36       36              
  Lines        2185     2194       +9     
==========================================
+ Hits         1073     1077       +4     
- Misses       1112     1117       +5     
Flag Coverage Δ
unitandintegration 49.08% <22.58%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/n_body/n_body_container.jl 0.00% <0.00%> (ø)
src/sph/neighborhood_search.jl 77.31% <0.00%> (-3.33%) ⬇️
src/semidiscretization/semidiscretization.jl 48.88% <10.52%> (ø)
test/unit/interactions/solid.jl 78.04% <50.00%> (-1.44%) ⬇️
src/containers/container.jl 72.22% <100.00%> (+1.63%) ⬆️
test/unit/containers/solid_container.jl 93.10% <100.00%> (+0.24%) ⬆️

Copy link
Collaborator

@LasNikas LasNikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! That makes a lot of things easier.

@LasNikas LasNikas merged commit a97cf11 into trixi-framework:main May 3, 2023
@efaulhaber efaulhaber deleted the update-nhs-with-array branch May 19, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants