Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test directory to coverage report #119

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

efaulhaber
Copy link
Member

All test code should be fully covered. If not, that means that we forgot to include a test file. The coverage report should include the test directory, so that we can immediately spot something like this.

@efaulhaber efaulhaber added the testing Improvements or additions to tests label Apr 19, 2023
@efaulhaber efaulhaber requested a review from LasNikas April 19, 2023 13:14
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #119 (85b0ed5) into main (41d93ed) will increase coverage by 3.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   41.47%   44.73%   +3.26%     
==========================================
  Files          27       34       +7     
  Lines        1999     2157     +158     
==========================================
+ Hits          829      965     +136     
- Misses       1170     1192      +22     
Flag Coverage Δ
unitandintegration 44.73% <ø> (+3.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LasNikas LasNikas merged commit 296b013 into trixi-framework:main Apr 20, 2023
@efaulhaber efaulhaber deleted the coverage-for-tests branch May 19, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants