Merge shapes #115
Merged
Merge shapes #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 50.32% 50.47% +0.15%
==========================================
Files 37 38 +1
Lines 2186 2193 +7
==========================================
+ Hits 1100 1107 +7
Misses 1086 1086
Flags with carried forward coverage won't be shown. Click here to find out more.
|
efaulhaber
requested changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a merge-shapes functionality to easily concatenate multiple shapes.
This makes the example files way more readable. I applied it to the
oscillating_beam_2dexample.Also, this functionality is very useful when we set up a backward-facing step simulation, for example.