Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @autoinfiltrate for simple, ad-hoc interactive debugging #1465

Merged
merged 3 commits into from
May 15, 2023
Merged

Add @autoinfiltrate for simple, ad-hoc interactive debugging #1465

merged 3 commits into from
May 15, 2023

Conversation

sloede
Copy link
Member

@sloede sloede commented May 15, 2023

@sloede sloede requested review from jlchan and patrickersing May 15, 2023 09:44
ranocha
ranocha reviewed May 15, 2023
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested it with all options?

src/auxiliary/auxiliary.jl Show resolved Hide resolved
@sloede
Copy link
Member Author

sloede commented May 15, 2023

I assume you tested it with all options?

I did, but not thoroughly enough as it seems. Please hold off further reviews until I figure this out, sorry.

@sloede
Copy link
Member Author

sloede commented May 15, 2023

I assume you tested it with all options?

I did, but not thoroughly enough as it seems. Please hold off further reviews until I figure this out, sorry.

Now everything should work as advertised.

@sloede sloede requested a review from ranocha May 15, 2023 11:43
jlchan
jlchan approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me! Thanks for adding this.

@sloede sloede mentioned this pull request May 15, 2023
Merged
@ranocha ranocha merged commit 2ddf030 into main May 15, 2023
@ranocha ranocha deleted the msl/add-at-autoinfiltrate branch May 15, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranocha ranocha ranocha approved these changes

@jlchan jlchan jlchan approved these changes

@patrickersing patrickersing Awaiting requested review from patrickersing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for easy @infiltrate
3 participants
@sloede @jlchan @ranocha