Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed optimization #22942

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Aug 5, 2024

Since FasterXML/jackson-core#1081 this optimization does no longer make sense as it's applied internally by Jackson if needed.

Alternative to #22941

Since FasterXML/jackson-core#1081 this optimization
does no longer make sense as it's applied internally by Jackson if needed.
@wendigo wendigo requested a review from pettyjamesm August 5, 2024 19:14
@cla-bot cla-bot bot added the cla-signed label Aug 5, 2024
@wendigo wendigo requested a review from electrum August 5, 2024 19:14
@wendigo wendigo merged commit 89cd867 into master Aug 6, 2024
104 checks passed
@wendigo wendigo deleted the serafin/remove-workaround branch August 6, 2024 05:01
@github-actions github-actions bot added this to the 454 milestone Aug 6, 2024
@Dith3r
Copy link
Member

Dith3r commented Aug 6, 2024

Flow with InputStreamReader cannot trigger optimization with StringReader, and additionally it creates 8kb Heap byte buffer for every Slice. JFRs and benchmarks were created with Jackson with patch and there is still difference 50% in CPU time with and without this part of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants