Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default Node.js version to 'lts/*' #1747

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update default Node.js version to 'lts/*' #1747

wants to merge 4 commits into from

Conversation

BanzaiMan
Copy link
Contributor

No description provided.

@BanzaiMan
Copy link
Contributor Author

Test: https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/743257

@BanzaiMan BanzaiMan mentioned this pull request Jul 17, 2019
Closed
@BanzaiMan
Copy link
Contributor Author

Coincidentally, default on windows doesn't seem to work currently. https://travis-ci.org/BanzaiMan/travis_production_test/jobs/560066644

@BanzaiMan BanzaiMan deployed to org-staging July 17, 2019 18:17 Active
@BanzaiMan BanzaiMan temporarily deployed to travis-build-staging July 17, 2019 18:17 Inactive
@BanzaiMan
Copy link
Contributor Author

Testing on Windows: https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/743259

@dominykas dominykas mentioned this pull request Jul 25, 2019
Closed
@BanzaiMan
Copy link
Contributor Author

Caching doesn't work for lts/*, so we need to fix that before changing the default.

@ljharb
Copy link
Contributor

ljharb commented Jul 30, 2019

Why doesn’t caching work for that?

Separately, you may want to hold off - I’m planning to add lts/-1 etc to nvm in the next couple weeks, so a better default might be lts/-2 which would be the oldest LTS instead of the newest one.

@BanzaiMan
Copy link
Contributor Author

Because the / is the path separator and that cause the archive name to be invalid.

@BanzaiMan
Copy link
Contributor Author

…or so I thought, but it seems to be working? https://travis-ci.org/BanzaiMan/travis_production_test/jobs/566660374#L181

@BanzaiMan BanzaiMan force-pushed the ha-default-node-lts branch from 4f147c3 to 524796a Compare August 5, 2019 14:55
ljharb
ljharb reviewed Aug 5, 2019
View reviewed changes
lib/travis/build/script/node_js.rb
name: 'Node.js',
current_default: '0.10',
new_default: 'lts/*',
cutoff_date: '2019-09-01',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be great if you could delay this, pending lts/-2 being available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. This date is completely arbitrary.

@vitalied vitalied force-pushed the master branch 13 times, most recently from 0621487 to 189cc37 Compare April 6, 2023 14:25
@vitalied vitalied force-pushed the master branch 4 times, most recently from 5f52bac to 39a2872 Compare April 6, 2023 15:25
@vitalied vitalied force-pushed the master branch 4 times, most recently from b550246 to e10c3aa Compare August 2, 2023 13:40
@vitalied vitalied force-pushed the master branch 7 times, most recently from 1a44841 to 4d03828 Compare August 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BanzaiMan @ljharb