README: document more building tricks #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
We don't support 1.68+ yet, due to their use of LLVM 16. See: #267. Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Jul 2, 2023
There was a problem hiding this comment.
This is unfortunate, but IMO produces a better user experience than our current one: the current UX is that cargo build or cargo install will complete successfully, but will fail to analyze any IR produced by versions of rustc newer than 1.67.
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Jul 2, 2023
Comment on lines
88
to
92
| let rsup_default = Command::new("rustup") | ||
| .arg("default") | ||
| .args(["show", "active-toolchain"]) | ||
| .output() | ||
| .expect("failed to run rustup to configure toolchain"); | ||
| let utf8_toolchain = std::str::from_utf8(&rsup_default.stdout) |
There was a problem hiding this comment.
We now use rustup show active-toolchain to determine the toolchain to use. This should be slightly more reliable than rustup default, in the sense that it'll both respect user overrides and should (?) respect the local rust-toolchain.toml in any crate.
smoelius
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.