Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): handles fields and collections naming conflicts in snapshot files #119

Merged
merged 5 commits into from
Nov 14, 2024
Merged

fix(cli): handles fields and collections naming conflicts in snapshot files #119

merged 5 commits into from
Nov 14, 2024

Conversation

EdouardDem
Copy link
Member

If 2 collection and folder (or field and group) have the same name (regardless the casing), then a suffix is added to the JSON's filename where the snapshot is saved.

@EdouardDem EdouardDem linked an issue Nov 14, 2024 that may be closed by this pull request
Extension deletes field if alias has the same name #116
Closed
@EdouardDem EdouardDem changed the base branch from main to next November 14, 2024 19:10
@EdouardDem EdouardDem merged commit f59558c into next Nov 14, 2024
4 checks passed
@EdouardDem EdouardDem deleted the 116-group-and-field-names-conflict branch November 14, 2024 19:13
EdouardDem added a commit that referenced this pull request Nov 21, 2024
@EdouardDem
fix(cli): handles fields and collections naming conflicts in snapshot…
955233a 
… files (#119) (#120)

* feat(e2e): add test

* feat(e2e): add test for colletions  conflicts

* fix(e2e): test for colletions

* fix(cli): deal fields and collection naming conflicts

* chore: update package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension deletes field if alias has the same name
1 participant
@EdouardDem