.NET Core refactor #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hasn't been tested yet; there will likely be bug fixes one it has been.
This time everything is tested and works, and a nuget package is being generated.
bgradin
force-pushed
the
feature/aspnetcore
branch
5 times, most recently
from
ac1cbf0 to
25df6df
Compare
bgradin
force-pushed
the
feature/aspnetcore
branch
from
25df6df to
dd6339f
Compare
bgradin
requested review from
matthinz and
tantalic
and removed request for
matthinz
bgradin
force-pushed
the
feature/aspnetcore
branch
from
d697d70 to
026e89d
Compare
…aspnetcore # Conflicts: # .travis.yml # Toolhouse.Monitoring.Tests/Toolhouse.Monitoring.Tests.csproj # Toolhouse.Monitoring/Properties/AssemblyInfo.cs # Toolhouse.Monitoring/Toolhouse.Monitoring.csproj
bgradin
force-pushed
the
feature/aspnetcore
branch
from
026e89d to
208c800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core Refactor
Goal: To get Toolhouse.Monitoring working with .NET Core, in order to facilitate development of ASP.NET Core projects
Framework Targets: .NET v4.5.1, .NET v4.6, .NET v4.6.1, .NET Core v2.0
Status: Tested in .NET 4.6.1 and .NET Core v2.0, no errors found
API Changes
Non-ASP.NET Core
For non-ASP.NET Core projects, the API stays completely the same, except for one small change: Instead of creating a database dependency with:
you use:
ASP.NET Core
See the sections added to the docs for information about the new ASP.NET Core API