fix: handle grouped profile experiences in get_profile_experiences #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an linting error, I did a format with ruff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is related to the issue 451
When dealing with grouped experiences (e.g. multiple positions at the same company) the API response will contain multiple indexes in data["included"].
The index with the most elements will contain probably all experiences, both grouped and individual, while other indexes may only contain partial data for the grouped experiences.
Therefore, we want to use the index with the most items to ensure we process all experiences.
I tested it on two large profile (14 and 8 experiences) with grouped experiences