Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated node12 #18

Closed
MarkoSagadin opened this issue Apr 8, 2023 · 7 comments
Closed

Deprecated node12 #18

MarkoSagadin opened this issue Apr 8, 2023 · 7 comments

Comments

@MarkoSagadin
Copy link
Contributor

MarkoSagadin commented Apr 8, 2023

Hello,

I have been a happy user of your Github Action on several projects!

I have noticed some time ago that my workflows started emitting an warning related to the deprecation of the node12:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, thomaseizinger/[email protected]. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

I am super familiar with javascript and typescript, but I could take a look at the issue.

Could you give me some hints where should I start looking?

I can see that action.yaml specifies node12, but there are also packages in the pacakge.json file that probably need to be updated.

@MarkoSagadin
Copy link
Contributor Author

I have forked the repo, updated node12 to node16 in actions.yml and ran the action from my test repo.
The warning disappeared.

From outside it seem that this is all that needs to be done, but I believe that probably some more work is needed.

MarkoSagadin added a commit to IRNAS/keep-a-changelog-new-release that referenced this issue Jul 11, 2023
@baynezy
Copy link

baynezy commented Nov 10, 2023

Is there any progress on this?

@thomaseizinger
Copy link
Owner

I have forked the repo, updated node12 to node16 in actions.yml and ran the action from my test repo.
The warning disappeared.

A PR needs to be created that makes this change.

MarkoSagadin added a commit to IRNAS/keep-a-changelog-new-release that referenced this issue Nov 13, 2023
@MarkoSagadin
Copy link
Contributor Author

@thomaseizinger A PR was created.

@thomaseizinger
Copy link
Owner

You should be able to reference the action now using the latest hash from master. If everything works as expected, I am happy to make a release after.

@MarkoSagadin
Copy link
Contributor Author

Hi @thomaseizinger, I have tested the commit, everything works as expected. You can make a release :)

@thomaseizinger
Copy link
Owner

Hi @thomaseizinger, I have tested the commit, everything works as expected. You can make a release :)

Sorry for the excessively long wait. This is now released as v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants