Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type guard! #39

Closed
rkatic opened this issue Apr 27, 2020 · 0 comments
Closed

Wrong type guard! #39

rkatic opened this issue Apr 27, 2020 · 0 comments

Comments

@rkatic
Copy link
Contributor

rkatic commented Apr 27, 2020 •
edited
Loading

The guard should use PromiseLike<T>, not Promise<T>.

If a thenable can be considered a Promise/A+ promise ("if it looks like a duck, it is a duck"), it certainly does not means it's also a ES Promise (which also has catch and finally).
Therefore the PromiseLike in TypeScript.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rkatic