Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated documentation and fixes incorrect Drawer (on Android) #33

Closed
wants to merge 3 commits into from
Closed

Updated documentation and fixes incorrect Drawer (on Android) #33

wants to merge 3 commits into from

Conversation

Zefau
Copy link

@Zefau Zefau commented Mar 5, 2019

  • Updated versions of dependencies within documentation according to package.json
  • Referenced issue App crashes immediately (Android) #22 within documentation in case App fails to start after renaming

Zefau added 3 commits March 5, 2019 18:14
@Zefau
Update README.md
1724cb2
@Zefau
updated versions
57082bd
@Zefau
fix Drawer on Android
6e1719e 
Addresses issue #32 with the drawer not sliding in. Solved by https://stackoverflow.com/a/53396072/10249387 (which has also been added to the Getting started at React Navigation (see https://kmagiera.github.io/react-native-gesture-handler/docs/getting-started.html#android).
@Zefau
Copy link
Author

Zefau commented Mar 7, 2019

Fixes #32
See https://stackoverflow.com/a/53396072/10249387 and https://kmagiera.github.io/react-native-gesture-handler/docs/getting-started.html#android

@Zefau Zefau changed the title Updated docs Updated documentation and fixes incorrect Drawer (on Android) Mar 7, 2019
@AurelGit
Copy link
Collaborator

AurelGit commented Apr 4, 2019 •
edited
Loading

Hey @Zefau thanks very much for your PR !
We've just merged #37, which includes your changes.

Thanks again :)

@AurelGit AurelGit closed this Apr 4, 2019
@parthjdabhi parthjdabhi mentioned this pull request Nov 29, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zefau @AurelGit