Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product card small screen tweaks #1941

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Product card small screen tweaks #1941

merged 2 commits into from
Jan 6, 2025

Conversation

hasparus
Copy link
Collaborator

@hasparus hasparus commented Jan 3, 2025

  • I tweaked width to min-width to make the blue and beige cards work the same.
  • The decoration is now nested in the anchor so it doesn't look weird in active style in mobile safari (where the decoration would glitch out being obscured by the anchor)
  • Also improved the story a bit.

Todo:

  • After review open the same thing against main v8 branch.

Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: 15d5e16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@theguild/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hasparus hasparus changed the title Product card mobile Product card mobile tweaks Jan 3, 2025
@hasparus hasparus changed the title Product card mobile tweaks Product card small screen tweaks Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

📚 Storybook Deployment

The latest changes are available as preview in: https://e9ac76f4.the-guild-docs-storybook.pages.dev

Copy link
Contributor

github-actions bot commented Jan 3, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/components 7.5.0-alpha-20250103174519-15d5e16548f3f7b4b59fef78388083fe3216382f npm ↗︎ unpkg ↗︎

@hasparus hasparus merged commit 0897591 into v7 Jan 6, 2025
5 checks passed
@hasparus hasparus deleted the product-card-mobile branch January 6, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants