Use /tmp for zookeeper.properties and startup script #7524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aids compatibility when running in more security-constrained environments, such as OpenShift, when using kubedock.
jonas-grgt
reviewed
Sep 13, 2023
| @@ -37,7 +37,7 @@ public class KafkaContainer extends GenericContainer<KafkaContainer> { | |||
|
|
|||
| private static final String DEFAULT_INTERNAL_TOPIC_RF = "1"; | |||
|
|
|||
| private static final String STARTER_SCRIPT = "/testcontainers_start.sh"; | |||
| private static final String STARTER_SCRIPT = "/tmp/testcontainers_start.sh"; | |||
There was a problem hiding this comment.
Maybe it would be possible to allow for the path to be fully configurable from the outside instead of hard coding it to /tmp ?
|
Hi, thanks for the PR. I think if we are going to do something like this then it should apply to all modules. No changes required. Will bring this PR to discuss with the team. |
35 tasks
kullmanp
reviewed
Oct 23, 2023
modules/kafka/src/main/java/org/testcontainers/containers/KafkaContainer.java
Outdated
Show resolved
Hide resolved
|
Thanks for your contribution, @kahowell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aids compatibility when running in more security-constrained environments, such as OpenShift, when using kubedock.
Fixes #8637