Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support containerised compose when running inside docker #1596

Closed
wants to merge 1 commit into from
Closed

Support containerised compose when running inside docker #1596

wants to merge 1 commit into from

Conversation

georgespalding
Copy link

Copy files into compose container instead of mounting them when testcontainers are used from within docker.

The suggested fix here is to detect if java/testcontainers is run inside a docker container, and if that is the case, copy files into the docker-compose container.

See #1557 (comment)

@georgespalding
Copy link
Author

/azp run Linux - native Docker

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1596 in repo testcontainers/testcontainers-java

@bsideup
Copy link
Member

bsideup commented Jul 9, 2019

Hi @georgespalding,

We generally recommend mapping the file system to the same path when the build is running inside a container.

Also, the suggested change won't work when Docker Compose file defines volume mappings and/or access the file system (e.g. for configs).

@georgespalding
Copy link
Author

  1. I apologize for opening the PR prematurely. I just found an error in how I'd try to do it: files cannot be copied before creation is done.
  2. I realize that all referenced files need to be in the list of mentioned configs, to make it work, the user has to supply all files referenced from the main compose file.
  3. I found a workaround for bitbucket

I will proceed to decline this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants