Support SELF typing for OracleContainer #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racleContainer class declaration
bsideup
reviewed
Apr 26, 2019
| @@ -7,7 +7,7 @@ | |||
| /** | |||
| * @author gusohal | |||
| */ | |||
| public class OracleContainer extends JdbcDatabaseContainer { | |||
| public class OracleContainer<SELF extends OracleContainer<SELF>> extends JdbcDatabaseContainer<SELF> { | |||
There was a problem hiding this comment.
It should be:
Suggested change
| public class OracleContainer<SELF extends OracleContainer<SELF>> extends JdbcDatabaseContainer<SELF> { | |
| public class OracleContainer extends JdbcDatabaseContainer<OracleContainer> { |
There was a problem hiding this comment.
So PostgreSQLContainer and MySQLContainer have also legacy class declaration, is it correct?
bsideup
reviewed
Apr 26, 2019
| @@ -108,4 +108,9 @@ public Integer getWebPort() { | |||
| public String getTestQueryString() { | |||
| return "SELECT 1 FROM DUAL"; | |||
| } | |||
|
|
|||
| @Override | |||
| protected void waitUntilContainerStarted() { | |||
There was a problem hiding this comment.
why do you need to override it?
There was a problem hiding this comment.
I checked PostgreSQLContainer and it overrides waitUntilContainerStarted method but after your comment i also checked MySQLContainer which does not. I suppose that WaitStrategy for most JdbcDatabaseContainer containers is the same.
There was a problem hiding this comment.
PostgreSQLContainer uses log-based wait strategy, while others inherit the JDBC one, hence the override
…od. Changed class declaration according.
bsideup
changed the title
bsideup
changed the title
kiview
approved these changes
Apr 26, 2019
kiview
changed the title
rnorth
approved these changes
Apr 27, 2019
|
Thank you @mumukiller! |
|
Released in 1.11.3. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added waitUntilContainerStarted method
Adjusted OracleContainer class declaration
Fixes #1423