Add Toxiproxy module #1330
Merged
Add Toxiproxy module #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Mar 21, 2019
| In either scenario, it is necessary to create a `ToxiproxyContainer` instance on the same Docker network, as follows: | ||
|
|
||
| <!--codeinclude--> | ||
| [Creating a Toxiproxy container](../../modules/toxiproxy/src/test/java/org/testcontainers/containers/ToxiproxyTest.java) inside_block:creatingProxy |
bsideup
reviewed
Mar 21, 2019
bsideup
reviewed
Mar 21, 2019
modules/toxiproxy/src/main/java/org/testcontainers/containers/ToxiproxyContainer.java
Show resolved
Hide resolved
bsideup
reviewed
Mar 21, 2019
modules/toxiproxy/src/main/java/org/testcontainers/containers/ToxiproxyContainer.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Mar 21, 2019
modules/toxiproxy/src/main/java/org/testcontainers/containers/ToxiproxyContainer.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Mar 21, 2019
modules/toxiproxy/src/main/java/org/testcontainers/containers/ToxiproxyContainer.java
Outdated
Show resolved
Hide resolved
|
This is brilliant :) |
|
Releasing this in 1.11.0 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://gist.github.com/rnorth/4c3666d62fa93bf0daa813b282e4ebff, in turn based on hotels.com’s blog post where they show use of Testcontainers with Toxiproxy.
Having seen Toxiproxy and experimented with it, I'm inclined to go with this and suggest that we not move forward with #283 (which is a great PR, but we've unfortunately failed to land after quite a long time). While Pumba may be nice and transparent, there are a lot of moving parts and complexity under the covers, vs Toxiproxy, which is a bit less magical but easier to understand.