-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get exitcode from inspectExecCmd #1318
Conversation
core/src/main/java/org/testcontainers/containers/Container.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/Container.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/Container.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: dmarkhas <[email protected]>
Co-Authored-By: dmarkhas <[email protected]>
Co-Authored-By: dmarkhas <[email protected]>
FYI I've pushed a small change (Lombok's Happy to merge after the CI reports green status, good job 👍 |
Thanks @bsideup , I did not find any other usages of this class in the project, and since it is not public I assumed it is safe to change the ctor signature. |
@dmarkhas it is public (defined as an inner class of an interface) |
Right, sorry :) |
@dmarkhas oh, no problem :) |
@dmarkhas merged, thanks! 👍 |
Releasing this in 1.11.0 🎉 |
Addresses #1309