update mockserver to 5.5.1 and bind to port 1080 which is default #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanwen
force-pushed
the
mockserver_551
branch
from
e48f135 to
d0b3c20
Compare
in 5.5.1 they don't run container as root, so binding to 80 port doesn't work anymore mock-server/mockserver@6d33bd7#diff-ebacf6f6ae4ee68078bb16454b23247d
lanwen
force-pushed
the
mockserver_551
branch
from
d0b3c20 to
a5a6f0e
Compare
bsideup
reviewed
Jan 2, 2019
modules/mockserver/src/test/java/org/testcontainers/containers/MockServerContainerTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Jan 2, 2019
modules/mockserver/src/test/java/org/testcontainers/containers/MockServerContainerTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Jan 2, 2019
modules/mockserver/src/test/java/org/testcontainers/containers/MockServerContainerTest.java
Outdated
Show resolved
Hide resolved
|
Looks great overall, but perhaps we should go with try-with-resources inside the test methods? It's barely any different in terms of length of code. However, people might want to refer to these tests as a kind of example, so it's probably best to be Lombok-agnostic... |
|
Thanks for the quick turnaround @lanwen. Let's merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 5.5.1 they don't run container as root, so binding to 80 port
doesn't work anymore
mock-server/mockserver@6d33bd7#diff-ebacf6f6ae4ee68078bb16454b23247d