-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CredsStore validation for RegistryAuthLocator (#1303)
## Fixes `RegistryAuthLocator` : Add additional validation for existing key `credsStore` but empty value ## Purpose Define behaviour for RegistryAuthLocator on empty values in config Offer: - fail on empty value - ignore field with empty value & log -> return null; ## Background Context Currently experienced problems using testcontainers, I found existing issue for my problem and decided to help. Potentially, put checks for all existing `keys` with empty strings ## References ref: #921
- Loading branch information
Showing
3 changed files
with
23 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
core/src/test/resources/auth-config/config-with-store-empty.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"auths": { | ||
"registry.example.com": {} | ||
}, | ||
"HttpHeaders": { | ||
"User-Agent": "Docker-Client/18.03.0-ce (darwin)" | ||
}, | ||
"credsStore": "" | ||
} |