Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/kafka: Enhancements for General Availability Release #8850

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 4, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8823

Release note for CHANGELOG:

ENHANCEMENTS

* data-source/aws_msk_cluster: Add `bootstrap_brokers_tls` attribute
* resource/aws_msk_cluster: Add `bootstrap_brokers_tls` attribute
* resource/aws_msk_cluster: Support `broker_node_group_into` configuration block `ebs_volume_size` argument updates
* resource/aws_msk_cluster: Add `client_authentication` configuration block
* resource/aws_msk_cluster: Add `configuration_info` configuration block
* resource/aws_msk_cluster: Add `current_version` attribute
* resource/aws_msk_cluster: Add `encryption_info` configuration block `encryption_in_transit` configuration block
* resource/aws_msk_cluster: Support tagging on creation

Output from acceptance testing:

--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker (895.20s)
--- PASS: TestAccAWSMskCluster_basic (994.37s)
--- PASS: TestAccAWSMskCluster_NumberOfBrokerNodes (1005.95s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn (1058.52s)
--- PASS: TestAccAWSMskCluster_Tags (1088.06s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster (1089.38s)
--- PASS: TestAccAWSMskCluster_EnhancedMonitoring (1100.27s)
--- PASS: TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize (1383.23s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. labels Jun 4, 2019
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 4, 2019
@bflad bflad mentioned this pull request Jun 4, 2019
Reference: #8823

* data-source/aws_msk_cluster: Add `bootstrap_brokers_tls` attribute
* resource/aws_msk_cluster: Add `bootstrap_brokers_tls` attribute
* resource/aws_msk_cluster: Support `broker_node_group_into` configuration block `ebs_volume_size` argument updates
* resource/aws_msk_cluster: Add `client_authentication` configuration block
* resource/aws_msk_cluster: Add `configuration_info` configuration block
* resource/aws_msk_cluster: Add `current_version` attribute
* resource/aws_msk_cluster: Add `encryption_info` configuration block `encryption_in_transit` configuration block
* resource/aws_msk_cluster: Support tagging on creation

Output from acceptance testing:

```
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker (895.20s)
--- PASS: TestAccAWSMskCluster_basic (994.37s)
--- PASS: TestAccAWSMskCluster_NumberOfBrokerNodes (1005.95s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn (1058.52s)
--- PASS: TestAccAWSMskCluster_Tags (1088.06s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster (1089.38s)
--- PASS: TestAccAWSMskCluster_EnhancedMonitoring (1100.27s)
--- PASS: TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize (1383.23s)
```
@bflad bflad force-pushed the f-aws_msk_cluster-ga branch from d83ceb1 to ae20bee Compare June 4, 2019 21:15
@bflad bflad requested a review from a team June 4, 2019 21:16
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v2.14.0 milestone Jun 5, 2019
@bflad bflad merged commit 7c9690f into master Jun 5, 2019
@bflad bflad deleted the f-aws_msk_cluster-ga branch June 5, 2019 20:42
bflad added a commit that referenced this pull request Jun 5, 2019
akatrevorjay added a commit to WhistleLabs/terraform-provider-aws that referenced this pull request Jun 6, 2019
* upstream/master: (39 commits)
  Update CHANGELOG for hashicorp#8850
  tests/provider: Add tfproviderlint and enable S001-S005 checks
  service/kafka: Changes for General Availability Release
  chore(deps): update module hashicorp/terraform to v0.12.1
  deps: github.com/golangci/golangci-lint/cmd/golangci-lint@de1d1ad903cd
  Update CHANGELOG.md
  Update CHANGELOG for hashicorp#6322
  Retry timeout error for acmpca cert authority
  Add nil check for S3 bucket metric filter
  Update cloudwatch_event_target.html.markdown
  Update module aws/aws-sdk-go to v1.19.42
  Add a nil check for reading spot options
  Update waf_sql_injection_match_set.html.markdown
  Document the aws_ssm_activation "id" attribute
  aws_subnet: Increase timeout for delete to 20 mins
  Secure basic CloudTrail example
  docs/resource/aws_route53_record: Add NS and SOA Record Management example
  Update default example to use json instead of form
  tests/service/waf: Add PreCheck for service availability
  tests/service/transfer: Add PreCheck for service availability
  ...
@bflad
Copy link
Contributor Author

bflad commented Jun 7, 2019

This has been released in version 2.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

bflad added a commit that referenced this pull request Jun 7, 2019
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon MSK GA features
2 participants