Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amazon MSK GA features #8823

Closed
ewbankkit opened this issue May 31, 2019 · 4 comments · Fixed by #8850
Closed

Amazon MSK GA features #8823

ewbankkit opened this issue May 31, 2019 · 4 comments · Fixed by #8850
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service.
Milestone
v2.14.0

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Additional features for Amazon MSK GA.

aws_msk_cluster

Broker storage can now be updated but not sure how this fits with the current resource model.

Related:
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label May 31, 2019
@bflad bflad added the service/kafka Issues and PRs that pertain to the kafka service. label May 31, 2019
bflad added a commit that referenced this issue Jun 4, 2019
@bflad
service/kafka: Changes for General Availability Release
d83ceb1 
Reference: #8823

* data-source/aws_msk_cluster: Add `bootstrap_brokers_tls` attribute
* resource/aws_msk_cluster: Add `bootstrap_brokers_tls` attribute
* resource/aws_msk_cluster: Support `broker_node_group_into` configuration block `ebs_volume_size` argument updates
* resource/aws_msk_cluster: Add `client_authentication` configuration block
* resource/aws_msk_cluster: Add `configuration_info` configuration block
* resource/aws_msk_cluster: Add `current_version` attribute
* resource/aws_msk_cluster: Add `encryption_info` configuration block `encryption_in_transit` configuration block
* resource/aws_msk_cluster: Support tagging on creation
@bflad bflad mentioned this issue Jun 4, 2019
Merged
@bflad
Copy link
Contributor

bflad commented Jun 4, 2019 •
edited
Loading

Work in progress pull request submitted: #8850

bflad added a commit that referenced this issue Jun 4, 2019
@bflad
service/kafka: Changes for General Availability Release
ae20bee 
Reference: #8823

* data-source/aws_msk_cluster: Add `bootstrap_brokers_tls` attribute
* resource/aws_msk_cluster: Add `bootstrap_brokers_tls` attribute
* resource/aws_msk_cluster: Support `broker_node_group_into` configuration block `ebs_volume_size` argument updates
* resource/aws_msk_cluster: Add `client_authentication` configuration block
* resource/aws_msk_cluster: Add `configuration_info` configuration block
* resource/aws_msk_cluster: Add `current_version` attribute
* resource/aws_msk_cluster: Add `encryption_info` configuration block `encryption_in_transit` configuration block
* resource/aws_msk_cluster: Support tagging on creation

Output from acceptance testing:

```
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker (895.20s)
--- PASS: TestAccAWSMskCluster_basic (994.37s)
--- PASS: TestAccAWSMskCluster_NumberOfBrokerNodes (1005.95s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn (1058.52s)
--- PASS: TestAccAWSMskCluster_Tags (1088.06s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster (1089.38s)
--- PASS: TestAccAWSMskCluster_EnhancedMonitoring (1100.27s)
--- PASS: TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize (1383.23s)
```
@bflad bflad added this to the v2.14.0 milestone Jun 5, 2019
@bflad
Copy link
Contributor

bflad commented Jun 5, 2019 •
edited
Loading

The following has been merged:

  • data-source/aws_msk_cluster: Add bootstrap_brokers_tls attribute
  • resource/aws_msk_cluster: Add bootstrap_brokers_tls attribute
  • resource/aws_msk_cluster: Support broker_node_group_into configuration block ebs_volume_size argument updates
  • resource/aws_msk_cluster: Add client_authentication configuration block
  • resource/aws_msk_cluster: Add configuration_info configuration block
  • resource/aws_msk_cluster: Add current_version attribute
  • resource/aws_msk_cluster: Add encryption_info configuration block encryption_in_transit configuration block
  • resource/aws_msk_cluster: Support tagging on creation

And will release with version 2.14.0 of the Terraform AWS Provider, likely tomorrow. 👍

@bflad
Copy link
Contributor

bflad commented Jun 7, 2019

This has been released in version 2.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service.
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging a pull request may close this issue.

service/kafka: Enhancements for General Availability Release hashicorp/terraform-provider-aws
2 participants
@bflad @ewbankkit