Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cloud Storage): Add bucket encryption sample #444

Merged

Conversation

betsy-lichtenberg
Copy link
Contributor

Description

Fixes # b/284014407

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@betsy-lichtenberg betsy-lichtenberg requested review from a team as code owners June 7, 2023 19:52
@snippet-bot
Copy link

snippet-bot bot commented Jun 7, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor Author

@betsy-lichtenberg betsy-lichtenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error in the logs is Error: googleapi: Error 403: Permission denied on Cloud KMS key. Please ensure that your Cloud Storage service account has been authorized to use this key., forbidden

But the sample does give permission on lines 112-118

@msampathkumar msampathkumar changed the title Added bucket encryption feat(Cloud Storage): Add bucket encryption sample Jun 9, 2023
@msampathkumar msampathkumar self-assigned this Jun 9, 2023
@msampathkumar
Copy link
Contributor

msampathkumar commented Jun 9, 2023

I got the same error Error 403: Permission denied on Cloud KMS key on the first try! During the re-run this error did not happen.

But I see Error: Error creating KeyRing: googleapi: Error 409: KeyRing projects/.../locations/us/keyRings/test-terraform-state already exists. during re-runs

@msampathkumar msampathkumar enabled auto-merge (squash) June 9, 2023 13:45
@betsy-lichtenberg
Copy link
Contributor Author

briangrant@ said:

That looks like an API problem.

https://buganizer.corp.google.com/issues/261484976

We're adding stronger API guidance on that topic:
aip-dev/google.aip.dev#1060

@msampathkumar msampathkumar disabled auto-merge June 13, 2023 12:43
Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

All 5 successful checks passed

storage/flask_google_cloud_quickstart/main.tf Outdated Show resolved Hide resolved
storage/flask_google_cloud_quickstart/main.tf Show resolved Hide resolved
@msampathkumar msampathkumar merged commit f35b22f into terraform-google-modules:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants