actionType is not checked before calling searchContextProviders() in updateEntity() function

[fgalan]

We have found that updateEntity() functions calls indiscriminately searchContextProviders() no matter the action type, i.e. even with APPEND and APPEND_STRICT. See the following fragment, at the end of updateEntity():

  /* To finish with this entity processing, search for CPrs in not found attributes and
   * add the corresponding ContextElementResponse to the global response */
  searchContextProviders(tenant, servicePathV, *enP, ceP->contextAttributeVector, cerP);

And compare with a similar (and correct) call in the creation entity flow:

    if ((strcasecmp(action.c_str(), "update") == 0) || (strcasecmp(action.c_str(), "replace") == 0))
    {
      /* In the case of UPDATE or REPLACE we look for context providers */
      searchContextProviders(tenant, servicePathV, *enP, ceP->contextAttributeVector, cerP);
      cerP->statusCode.fill(SccOk);
      ...
    }

We are not sure if we have a functional test covering update context APPEND with CPr registration in place covering this case. That should be the first thing to check.

It could also happen that we have a funct test, but some other part of the code (e.g. the forwarding logic) is "masking" the problem at updateEntity().

[fgalan]

Flow diagram MB-03 should be changed once this issue gets completed.

[fgalan]

Flow diagram MB-05 should be changed once this issue gets completed.

[fgalan]

Fixed (code) in PR #3177

[ghost]

Hi @fgalan Sir,
Thanks for your continuous support.
Do i have to change Flow diagram MB-03 and MB-05, to close this bug. If yes, please guide me so we can close this issue.
Thank you

[fgalan]

No, don't worry. I'll deal with modifications on MB-03 and MB-05. You can skip to the next item to contribute, if you want to continue ;)

[fgalan]

MB-03 and MB-05 fixed in PR #3203