Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the webhook name to triggers-webhook #829

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Change the webhook name to triggers-webhook #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/webhook/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,10 @@ func main() {
SecretName: secretName,
})

sharedmain.WebhookMainWithConfig(ctx, "webhook",
// NOTE(afrittoli) - we should have the name "webhook-triggers"
// configurable. Once the change is done on knative/pkg side
// knative/eventing#4530 we can inherit it from it
sharedmain.WebhookMainWithConfig(ctx, "webhook-triggers",
sharedmain.ParseAndGetConfigOrDie(),
certificates.NewController,
NewDefaultingAdmissionController,
Expand Down