Add support for ClusterTriggerBinding #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/hold
tekton-robot
added
the
size/XXL
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
khrm
reviewed
Jan 20, 2020
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
/test pull-tekton-triggers-integration-tests |
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
dibyom
reviewed
Jan 30, 2020
| @@ -155,6 +153,19 @@ func TestEventListenerCreate(t *testing.T) { | |||
| t.Fatalf("Error creating TriggerBinding: %s", err) | |||
| } | |||
|
|
|||
| // ClusterTriggerBinding | |||
| ctb, err := c.TriggersClient.TektonV1alpha1().ClusterTriggerBindings().Create( | |||
There was a problem hiding this comment.
Can we split this off into a separate test instead of adding onto existing test here since it is already pretty large?
There was a problem hiding this comment.
So, this is an e2e test, which was using a trigger binding. I have split that into one trigger binding and 1 cluster trigger binding and updated the test. Does it make sense to have two tests for that?
There was a problem hiding this comment.
I think its ok for now...but I'm planning on adding smaller/more focussed e2e tests soon!
|
The following is the coverage report on pkg/.
|
|
/test pull-tekton-triggers-integration-tests |
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
dibyom
approved these changes
Feb 3, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This will add the support for ClusterTriggerBinding in triggers which is like TrigerBinding but cluster-scoped This is designed to encourage reusability across cluster You need to add Kind field along with TriggerBinding name to use ClusterTriggerBinding, by default it is TriggerBinding Add docs, examples, and tests for clustertriggerbinding Little refactoring in code. Add builders for multipleTriggerBindings in a trigger Refactored e2e test to use both triggerBinding and clusterTriggerBinding Closes tektoncd#322
|
The following is the coverage report on pkg/.
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This will add the support for ClusterTriggerBinding
in triggers which is like TrigerBinding but
cluster-scoped
This is designed to encourage reusability across cluster
You need to add Kind field along with TriggerBinding name
to use ClusterTriggerBinding, by default it is
TriggerBinding
Add docs, examples, and tests for clustertriggerbinding
Little refactoring in code.
Add builders for multipleTriggerBindings in a trigger
Refactored e2e test to use both triggerBinding and
clusterTriggerBinding
Closes #322
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes