Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove third_party directory #1579

Merged
merged 1 commit into from
May 31, 2023
Merged

Remove third_party directory #1579

merged 1 commit into from
May 31, 2023

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Apr 19, 2023

Changes

The third_party directory contains source code of some of our third_party dependencies that need to be distributed with the built images as required by their licenses. However, our publish-triggers-release task [1] already includes the source code of all of our dependencies in the image rendering the separate third_party directory redundant.

This is a port of tektoncd/pipeline#6416

[1]

# For each cmd/* directory, include a full gzipped tar of all source in
# vendor/. This is overkill. Some deps' licenses require the source to be
# included in the container image when they're used as a dependency.
# Rather than trying to determine which deps have this requirement (an(params.imageRegistryd
# probably get it wrong), we'll just targz up the whole vendor tree and
# include it. As of 9/20/2019, this amounts to about 11MB of additional
# data in each image.
TMPDIR=$(mktemp -d)
tar cfz ${TMPDIR}/source.tar.gz vendor/
for d in cmd/*; do
if [ -d ${d}/kodata/ ]; then
ln -s ${TMPDIR}/source.tar.gz ${d}/kodata/
fi
done

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

/kind misc

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Apr 19, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 19, 2023
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@khrm
Copy link
Contributor

khrm commented Apr 19, 2023

/test pull-tekton-triggers-build-tests

@dibyom
Copy link
Member Author

dibyom commented Apr 20, 2023

/assign @savitaashture

@dibyom
Copy link
Member Author

dibyom commented May 10, 2023

/retest

@khrm khrm modified the milestones: Triggers v0.24, Triggers v0.25 May 11, 2023
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2023
The third_party directory contains source code of some of our third_party
dependencies that need to be distributed with the built images as required by
their licenses. However, our publish-triggers-release task [1] already includes the
source code of all of our dependencies in the image rendering the separate
third_party directory redundant.

This is a port of tektoncd/pipeline#6416

[1] https://github.com/tektoncd/triggers/blob/2713832b025b804db4d8d7af48e4f944511b490f/tekton/publish.yaml#L104-L117

Signed-off-by: Dibyo Mukherjee <[email protected]>
@tekton-robot tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 12, 2023
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2023
@khrm
Copy link
Contributor

khrm commented May 31, 2023

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@tekton-robot tekton-robot merged commit 6ada7a0 into tektoncd:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants