-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove third_party directory #1579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-tekton-triggers-build-tests |
/assign @savitaashture |
/retest |
The third_party directory contains source code of some of our third_party dependencies that need to be distributed with the built images as required by their licenses. However, our publish-triggers-release task [1] already includes the source code of all of our dependencies in the image rendering the separate third_party directory redundant. This is a port of tektoncd/pipeline#6416 [1] https://github.com/tektoncd/triggers/blob/2713832b025b804db4d8d7af48e4f944511b490f/tekton/publish.yaml#L104-L117 Signed-off-by: Dibyo Mukherjee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
The third_party directory contains source code of some of our third_party dependencies that need to be distributed with the built images as required by their licenses. However, our publish-triggers-release task [1] already includes the source code of all of our dependencies in the image rendering the separate third_party directory redundant.
This is a port of tektoncd/pipeline#6416
[1]
triggers/tekton/publish.yaml
Lines 104 to 117 in 2713832
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
/kind misc