Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New TestEventListenerCreate test fail because cluster level resources are not deleted #418

Closed
zhangtbj opened this issue Feb 6, 2020 · 5 comments · Fixed by #420
Closed

New TestEventListenerCreate test fail because cluster level resources are not deleted #418

zhangtbj opened this issue Feb 6, 2020 · 5 comments · Fixed by #420
Assignees
@piyush-garg
Labels
area/testing Issues or PRs related to testing

Comments

@zhangtbj
Copy link
Contributor

zhangtbj commented Feb 6, 2020 •
edited
Loading

Expected Behavior

When I run the e2e test, it should pass as before

Actual Behavior

TestEventListenerCreate test fails because the cluster level resources are not deleted:

  1. clusterrolebinding.rbac.authorization.k8s.io "my-rolebinding"
  2. clusterrole.rbac.authorization.k8s.io "my-role"
  3. clustertriggerbinding.tekton.dev "my-clustertriggerbinding"

Steps to Reproduce the Problem

  1. have a new cluster
  2. run e2e test and DO NOT clean the environment
  3. re-run the e2e test, it will fail because cluster level resources are not deleted

Additional Info

https://github.com/tektoncd/triggers/blob/master/test/eventlistener_test.go#L156-L216

After I removed them manually, the second test passed.

Pls clean these resources after test
@dibyom
Copy link
Member

dibyom commented Feb 6, 2020

cc @piyush-garg

I wonder how CI is passing 🤔

@dibyom
Copy link
Member

dibyom commented Feb 6, 2020

/area testing

@tekton-robot tekton-robot added the area/testing Issues or PRs related to testing label Feb 6, 2020
@piyush-garg
Copy link
Contributor

/assign

@piyush-garg
Copy link
Contributor

@dibyom I think the CI is passing because we always spin a new environment for CI

piyush-garg added a commit to piyush-garg/triggers that referenced this issue Feb 6, 2020
@piyush-garg
Delete clusterscoped resource in teardown
d50faf8 
This will delete the clusterscoped resources we are creating
in event listener e2e tests during teardown

Fix tektoncd#418
@piyush-garg piyush-garg mentioned this issue Feb 6, 2020
Merged
3 tasks
tekton-robot pushed a commit that referenced this issue Feb 6, 2020
@piyush-garg @tekton-robot
Delete clusterscoped resource in teardown
7ba80a7 
This will delete the clusterscoped resources we are creating
in event listener e2e tests during teardown

Fix #418
@zhangtbj
Copy link
Contributor Author

zhangtbj commented Feb 7, 2020

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piyush-garg piyush-garg

Labels
area/testing Issues or PRs related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete clusterscoped resource in teardown piyush-garg/triggers
4 participants
@dibyom @zhangtbj @piyush-garg @tekton-robot