Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0118: Update PipelineTaskResultRefs for Matrix Include Parameters #6348

Merged
merged 1 commit into from
Mar 14, 2023
Merged

TEP-0118: Update PipelineTaskResultRefs for Matrix Include Parameters #6348

merged 1 commit into from
Mar 14, 2023

Conversation

EmmaMunley
Copy link
Contributor

@EmmaMunley EmmaMunley commented Mar 10, 2023 •
edited
Loading

Changes

[TEP-0090: Matrix] introduced Matrix to the PipelineTask specification such that the PipelineTask executes a list of TaskRuns or Runs in parallel with the specified list of inputs for a Parameter or with different combinations of the inputs for a set of Parameters.

To build on this, Tep-0018 introduced Matrix.Include, which allows passing in a specific combinations of Parameters into the Matrix.

This PR updates PipelineTaskResultRefs to include result references from matrix.params.include in the list of all result references from a PipelineTask .

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 10, 2023
@tekton-robot tekton-robot requested review from afrittoli and jerop March 10, 2023 19:23
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 10, 2023
@EmmaMunley
Copy link
Contributor Author

/hold
cc: @JeromeJu @jerop
This is branched off of this refactoring PR: #6344

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 96.9% 97.1% 0.2
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.0% -0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.3% 96.5% 0.2
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_types.go 96.9% 97.1% 0.2
pkg/apis/pipeline/v1/pipeline_validation.go 99.0% 99.0% -0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.3% 96.5% 0.2
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.1

@EmmaMunley EmmaMunley mentioned this pull request Mar 10, 2023
Closed
7 tasks
@jerop jerop added this to the Pipelines v0.46 milestone Mar 10, 2023
@EmmaMunley EmmaMunley mentioned this pull request Mar 13, 2023
Closed
16 tasks
@EmmaMunley EmmaMunley force-pushed the result-ref-matrix-include branch from 9585ede to af15640 Compare March 13, 2023 21:21
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2023
@EmmaMunley
Copy link
Contributor Author

/unhold @jerop @JeromeJu

@EmmaMunley EmmaMunley force-pushed the result-ref-matrix-include branch from af15640 to ddc343a Compare March 13, 2023 21:38
@jerop
Copy link
Member

jerop commented Mar 13, 2023

/unhold

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2023
@EmmaMunley
Copy link
Contributor Author

/retest-required

jerop
jerop approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message and PR description to say what this "update" is doing, for example:

This change updates PipelineTaskResultRefs to include result references from matrix.params.include in the list of all result references from a PipelineTask.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@EmmaMunley
TEP-0118: Update PipelineTaskResultRefs for Matrix Include Parameters
46920c3 
This commit updates PipelineTaskResultRefs to include result references from matrix.params.include in the list of all result references from a PipelineTas.

Note: This feature is still in preview mode.
@EmmaMunley EmmaMunley force-pushed the result-ref-matrix-include branch from ddc343a to 46920c3 Compare March 14, 2023 15:16
@jerop
Copy link
Member

jerop commented Mar 14, 2023

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@jerop: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmmaMunley
Copy link
Contributor Author

/test pull-tekton-pipeline-go-coverage

@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@tekton-robot tekton-robot merged commit f14b518 into tektoncd:main Mar 14, 2023
@EmmaMunley EmmaMunley deleted the result-ref-matrix-include branch March 15, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.46
Development

Successfully merging this pull request may close these issues.
4 participants
@EmmaMunley @tekton-robot @jerop @Yongxuanzhang