Hygiene: enable linters for error conventions.

[bendory]

Changes

There are no expected functional changes in this PR.

Made non-functional code changes to adhere to linter standards.

Context: #5899

See related style docs:

• Error naming
• Concision
• Error handling

/kind cleanup

Submitter Checklist

• [N/A] Has Docs included if any changes are user facing
• [N/A] Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: 

- `resolution.ErrorRequestedResourceIsNil` is deprecated; change references to `resolution.ErrNilResource`.
- `remote.ErrorRequestInProgress` is deprecated; change references to `remote.ErrRequestInProgress`.
- in package `cmd/entrypoint/subcommands`, `SubcommandSuccessful` type is deprecated, use type `OK`.
- in package `resolution/common`, `ErrorRequestInProgress` is deprecated; change references to `ErrRequestInProgress`.
- in package `resolution/common`, all errors of type `Error*` have been renamed to type `*Error`.
- in package `resolution/framework`, `ErrorMissingTypeSelector` is deprecated; change references to `ErrMissingTypeSelector`

Trusted Resources are in alpha; the following breaking changes are included in this PR:

- in package `trustedresources`:
  - `ErrorResourceVerificationFailed` is replaced by `ErrResourceVerificationFailed`
  - `ErrorEmptyVerificationConfig` is replaced by `ErrEmptyVerificationConfig`
  - `ErrorNoMatchedPolicies` is replaced by `ErrNoMatchedPolicies`
  - `ErrorRegexMatch` is replaced by `ErrRegexMatch`
  - `ErrorSignatureMissing` is replaced by `ErrSignatureMissing`
- in package `trustedresources/verifier`:
  - `ErrorFailedLoadKeyFile` is replaced by `ErrFailedLoadKeyFile`
  - `ErrorDecodeKey` is replaced by `ErrDecodeKey`
  - `ErrorEmptyPublicKeys` is replaced by `ErrEmptyPublicKeys`
  - `ErrorEmptySecretData` is replaced by `ErrEmptySecretData`
  - `ErrorSecretNotFound` is replaced by `ErrSecretNotFound`
  - `ErrorMultipleSecretData` is replaced by `ErrMultipleSecretData`
  - `ErrorEmptyKey` is replaced by `ErrEmptyKey`
  - `ErrorK8sSpecificationInvalid` is replaced by `ErrK8sSpecificationInvalid`
  - `ErrorLoadVerifier` is replaced by `ErrLoadVerifier`
  - `ErrorAlgorithmInvalid` is replaced by `ErrAlgorithmInvalid`

[bendory]

/retest-required

[bendory]

/test check-pr-has-kind-label

[tekton-robot]

@bendory: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-tekton-pipeline-alpha-integration-tests
• /test pull-tekton-pipeline-beta-integration-tests
• /test pull-tekton-pipeline-build-tests
• /test pull-tekton-pipeline-integration-tests
• /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

• /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Yongxuanzhang]

/lgtm

Thanks! There are lot of error naming changes in trusted resources. 😄

[bendory]

/test pull-tekton-pipeline-alpha-integration-tests

[lbernick]

qq: for these linter PRs, do you have any sense of how well these plugins are being maintained, and whether the plugins represent generally accepted code style or just the opinions of the plugin author? I'm curious because I don't see anything wrong with SubcommandSuccessful as a function name, but this linter seems to have a problem with it.

[bendory]

qq: for these linter PRs, do you have any sense of how well these plugins are being maintained, and whether the plugins represent generally accepted code style or just the opinions of the plugin author? I'm curious because I don't see anything wrong with SubcommandSuccessful as a function name, but this linter seems to have a problem with it.

It is maintained well enough that it's included by Go as a standard module; it's been adopted by Google, RedHat OpenShift, AWS, IBM, FaceBook, Netflix, and other major companies.

With regard to SubcommandSuccessful, that's against the error naming convention

[vdemeester]

Overall LGTM, one "nit" about not only renaming the error but maybe aliasing and mark as deprecated the old ones 👼🏼

[bendory]

/retest-required

[bendory]

/retest-required

[bendory]

/retest-required

[bendory]

Test failure is happening at main as well, so I don't think it's me...

[bendory]

/retest-required

[wlynch]

/lgtm

🎉 🎉 🎉

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, wlynch, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lbernick,wlynch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment