[release-0.44.x] picking up latest changes in knative 1.8 #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
kind/misc
tekton-robot
added
the
size/XS
tekton-robot
removed
the
do-not-merge/work-in-progress
Yongxuanzhang
force-pushed
the
bring-latest-knative-1.8-to-44
branch
from
1f4df0f to
c21d8f7
Compare
|
/retest |
pritidesai
approved these changes
Feb 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Yongxuanzhang
force-pushed
the
bring-latest-knative-1.8-to-44
branch
from
c21d8f7 to
7680aa2
Compare
knative.dev/pkg was recently updated to include a performance fix which helped reduced the CPU usage by 61% and memory usage by 44% for huge pipelines. This PR is updating the tekton controllers to include that fix such that Pipelines 0.44.x can take advantage of this performance improvement. The same fix was cherry picked in knative.dev/pkg 1.9. Tekton pipeline was updated to use knative 1.9 post 0.45 in PR tektoncd#6062. We have another PR tektoncd#6194 open to update pipeline controllers in the main branch. Signed-off-by: Yongxuan Zhang [email protected]
Yongxuanzhang
force-pushed
the
bring-latest-knative-1.8-to-44
branch
from
7680aa2 to
3c56da5
Compare
|
/lgtm |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is a result of:
knative.dev/pkg was recently updated to include a performance fix which helped reduced the CPU usage by 61% and memory usage by 44% for huge pipelines. This PR is updating the tekton controllers to include that fix such that Pipelines 0.43.x can take advantage of this performance improvement.
The same fix was cherry picked in knative.dev/pkg 1.9. Tekton pipeline was updated to use knative 1.9 post 0.45 in PR #6062. We have another PR #6194 open to update pipeline controllers in the main branch.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes