Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tekton development processes section URLs #6225

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Update Tekton development processes section URLs #6225

merged 1 commit into from
Feb 28, 2023

Conversation

pavanstarmanwar
Copy link
Contributor

@pavanstarmanwar pavanstarmanwar commented Feb 23, 2023 •
edited
Loading

Changes

  • Tekton development processes links are not pointing to the right URLs.
  • When accessing these links we get a 404 Page not found error and below note
 The 'tektoncd/community' repository doesn't contain the 'process.md' path in 'main'.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Feb 23, 2023
@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 23, 2023
@tekton-robot
Copy link
Collaborator

Hi @pavanstarmanwar. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 23, 2023
@pavanstarmanwar
Copy link
Contributor Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@pavanstarmanwar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pavanstarmanwar
Copy link
Contributor Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 23, 2023
@pavanstarmanwar
Copy link
Contributor Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@pavanstarmanwar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pavanstarmanwar
Copy link
Contributor Author

/remove-label kind/misc

@tekton-robot
Copy link
Collaborator

@pavanstarmanwar: The label(s) /remove-label kind/misc cannot be applied. These labels are supported: ``

In response to this:

/remove-label kind/misc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pavanstarmanwar
Copy link
Contributor Author

/remove-kind misc

@tekton-robot tekton-robot removed the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 23, 2023
@pritidesai
Copy link
Member

/ok-to-test

@pavanstarmanwar please add a note in the PR description explaining the changes. thanks!

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2023
@pritidesai pritidesai mentioned this pull request Feb 23, 2023
Closed
@pritidesai
Copy link
Member

/retest

@pavanstarmanwar
Copy link
Contributor Author

/retest-required

pritidesai
pritidesai reviewed Feb 24, 2023
View reviewed changes
CONTRIBUTING.md Outdated
- [Finding things to work on](https://github.com/tektoncd/community/tree/main/process#finding-something-to-work-on)
- [Proposing new features](https://github.com/tektoncd/community/tree/main/process#proposing-features)
- [Performing code reviews](https://github.com/tektoncd/community/tree/main/process#reviews)
- [Becoming a code owner](https://github.com/tektoncd/community/blob/main/OWNERS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @pavanstarmanwar for fixing broken links 👍

can you please replace the title and link with:

- [Becoming a community member and maintainer](https://github.com/tektoncd/community/blob/main/process/contributor-ladder.md)

@lbernick thoughts?

This `owners' link to showing a list of folks on Governing Board but the intention here it to showcase the Tekton contributor ladder to a new contributor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually replace this line with

- [Moving up the contributor ladder](https://github.com/tektoncd/community/tree/main/process/contributor-ladder.md)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made the above change and pushed a commit. :)
Let me know which one and I will update the same

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me!

@pritidesai
Copy link
Member

/retest

lbernick
lbernick approved these changes Feb 27, 2023
View reviewed changes
CONTRIBUTING.md Outdated
- [Finding things to work on](https://github.com/tektoncd/community/tree/main/process#finding-something-to-work-on)
- [Proposing new features](https://github.com/tektoncd/community/tree/main/process#proposing-features)
- [Performing code reviews](https://github.com/tektoncd/community/tree/main/process#reviews)
- [Becoming a code owner](https://github.com/tektoncd/community/blob/main/OWNERS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually replace this line with

- [Moving up the contributor ladder](https://github.com/tektoncd/community/tree/main/process/contributor-ladder.md)

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@pavanstarmanwar pavanstarmanwar force-pushed the update-development-process-urls branch from 9a90496 to 3750add Compare February 27, 2023 14:45
@pritidesai
Copy link
Member

thanks @pavanstarmanwar 👍

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@pritidesai
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit 2b00a62 into tektoncd:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@pritidesai pritidesai pritidesai left review comments

@afrittoli afrittoli Awaiting requested review from afrittoli

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavanstarmanwar @tekton-robot @pritidesai @lbernick