update pipeline-object-results example #6166
Conversation
tekton-robot
added
kind/misc
|
/assign @pritidesai |
| type: string | ||
| hello: | ||
| digest: | ||
| type: string | ||
| default: { |
There was a problem hiding this comment.
Shall we try dropping the default from here?
There was a problem hiding this comment.
I think it was added to show how to use default for object params, any reasons we want to drop it?
There was a problem hiding this comment.
I would suggest creating a separate section for documenting how to use default instead of mixing the functionality check and usage. We can add a separate example similar to how we have an example to show default usage for array params
Doc: https://github.com/tektoncd/pipeline/blob/main/docs/tasks.md#default-value
Example: https://github.com/tektoncd/pipeline/blob/main/examples/v1beta1/taskruns/array-default.yaml
There was a problem hiding this comment.
That sounds good to me!
|
/retest |
This commit updates the existinh pipeline-object-results example with more checks and logging messages. Signed-off-by: Yongxuan Zhang [email protected]
Yongxuanzhang
force-pushed
the
update-object-example
branch
from
a224e51 to
095f425
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
This commit updates the existinh pipeline-object-results example with more checks and logging messages.
/kind misc
Signed-off-by: Yongxuan Zhang [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes